[5/5] tools: Update to use 'parsemail --hash'

[Tom Rini]

On Thu, Dec 01, 2016 at 01:21:40PM +0000, Stephen Finucane wrote:
> On Tue, 2016-11-29 at 18:53 -0500, Tom Rini wrote:
> > On Fri, Nov 18, 2016 at 12:54:52AM +0000, Stephen Finucane wrote:
> > 
> > > This replaces the older 'parser' main function.
> > > 
> > > Signed-off-by: Stephen Finucane <stephen at that.guru>
> > > Cc: Paul Jakma <paul at jakma.org>
> > 
> > With this series on top of 2941d6f47fd242d53c52e966501fb09e2eb19473 I
> > don't have success, but instead:
> > Traceback (most recent call last):
> >   File "/home/trini/work/u-boot/patchwork/manage.py", line 11, in
> > <module>                  execute_from_command_line(sys.argv)
> >   File "/usr/lib/python2.7/dist-
> > packages/django/core/management/__init__.py", line 399, in
> > execute_from_command_line
> >     utility.execute()
> >   File "/usr/lib/python2.7/dist-
> > packages/django/core/management/__init__.py", line 392, in execute
> >     self.fetch_command(subcommand).run_from_argv(self.argv)
> >   File "/usr/lib/python2.7/dist-
> > packages/django/core/management/base.py", line 242, in run_from_argv
> >     self.execute(*args, **options.__dict__)
> >   File "/usr/lib/python2.7/dist-
> > packages/django/core/management/base.py", line 285, in execute
> >     output = self.handle(*args, **options)
> >   File "/home/trini/work/u-
> > boot/patchwork/patchwork/management/commands/parsemail.py", line 69,
> > in
> > handle                                                               
> >             infile = args[0] if args else
> > options['infile']                                     KeyError:
> > 'infile'
> > 
> > And if I don't pass PW_PYTHON=python2:
> > ./post-receive.hook: line 38: PW_PYTHON: unbound variable
> > 
> > I also need to set DJANGO_SETTINGS_MODULE=patchwork.settings.dev
> > because
> > the default of 'production' assumes a bunch of other stuff has been
> > setup and configured.
> > 
> > A related tangent, as an end user I'm finding top of tree way way
> > harder
> > to get going with than v1.1.1.
> 
> Does this relate to the script / hook functionality only, or are there
> other usability issues you've seen in deploying 'master'?

I'm just talking about the hook here, we use the ozlabs patchwork
instance for patchwork on U-Boot.

> > From the point of view of a script /
> > hook that will be used very disconnected from the patchwork server it
> > seems like things are taking a step backwards in terms of ease of
> > use.
> 
> I hear you: usage of this script on a different server from the one
> that Patchwork is hosted from is a clear use case, but one I didn't
> consider when writing v1 of this series. Hopefully v3 of this is more
> to your liking. Let me know.

Yes, this solved all of my concerns in that regard, I purged django from
my system and was able to run the tools again.  This is important
because I don't want to install more stuff than is strictly required on
the git server.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20161201/92b7a2d9/attachment-0001.sig>