[PATCH 3/3] pwclient: Fix Python 3 encoding of received strings
Thomas Monjalon
thomas.monjalon at 6wind.com
Sat Dec 10 12:32:32 AEDT 2016
The conversion encode("utf-8") makes a byte stream which is
poorly printed with Python 3.
However this encoding is required for Popen.communicate() but must be
done after str.join() which applies to a real string.
Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
---
patchwork/bin/pwclient | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/patchwork/bin/pwclient b/patchwork/bin/pwclient
index 42a7fd0..5a9e93c 100755
--- a/patchwork/bin/pwclient
+++ b/patchwork/bin/pwclient
@@ -269,7 +269,7 @@ def action_check_info(rpc, check_id):
print(s)
print('-' * len(s))
for key, value in sorted(check.items()):
- print("- %- 14s: %s" % (key, unicode(value).encode("utf-8")))
+ print("- %- 14s: %s" % (key, unicode(value)))
def action_check_create(rpc, patch_id, context, state, url, description):
@@ -293,7 +293,7 @@ def action_info(rpc, patch_id):
print(s)
print('-' * len(s))
for key, value in sorted(patch.items()):
- print("- %- 14s: %s" % (key, unicode(value).encode("utf-8")))
+ print("- %- 14s: %s" % (key, unicode(value)))
def action_get(rpc, patch_id):
@@ -311,7 +311,7 @@ def action_get(rpc, patch_id):
i += 1
with open(fname, 'w') as f:
- f.write(unicode(s).encode("utf-8"))
+ f.write(unicode(s))
print('Saved patch to %s' % fname)
@@ -748,15 +748,15 @@ def main():
for patch_id in non_empty(h, patch_ids):
s = rpc.patch_get_mbox(patch_id)
if len(s) > 0:
- i.append(unicode(s).encode("utf-8"))
+ i.append(unicode(s))
if len(i) > 0:
- pager.communicate(input="\n".join(i))
+ pager.communicate(input="\n".join(i).encode("utf-8"))
pager.stdin.close()
else:
for patch_id in non_empty(h, patch_ids):
s = rpc.patch_get_mbox(patch_id)
if len(s) > 0:
- print(unicode(s).encode("utf-8"))
+ print(unicode(s))
elif action == 'info':
for patch_id in non_empty(h, patch_ids):
--
2.7.0
More information about the Patchwork
mailing list