[PATCH v3 1/5] parser: Remove unused parameter

Stephen Finucane stephen at that.guru
Fri Dec 2 21:13:50 AEDT 2016


On Fri, 2016-12-02 at 12:13 +1100, Daniel Axtens wrote:
> Looks good to me.
> 
> Happily this should make the tests a little faster, which is always
> nice :)
> 
> > diff --git a/patchwork/tests/test_parser.py
> > b/patchwork/tests/test_parser.py
> > index 96166ad..e4a379d 100644
> > --- a/patchwork/tests/test_parser.py
> > +++ b/patchwork/tests/test_parser.py
> > @@ -62,7 +62,7 @@ def read_mail(filename, project=None):
> >              mail = email.message_from_file(f)
> >      if 'Message-Id' not in mail:
> >          mail['Message-Id'] = make_msgid()
> > -    if project is not None:
> > +    if project:
> >          mail['List-Id'] = project.listid
> >      return mail
> 
> This is just a 'clean up while I'm editing this file' change, right?

Aye, not really necessary but I'll keep it for now :)

> Reviewed-by: Daniel Axtens <dja at axtens.net>

Excellent. Applied.

Stephen


More information about the Patchwork mailing list