[PATCH v2 2/4] docs: Make Docker the recommended install method

Daniel Axtens dja at axtens.net
Wed Aug 31 10:07:52 AEST 2016


Your changes look good - I did find a couple of other minor nits though:

> +To run unit tests, excluding Selenium UI interaction tests, using only the
> +package versions provided by the container, run:
> +
> +    $ docker-compose run --rm web --quick-test

I'm not quite sure this is correct. In terms of python packages, it uses
the versions installed by pip. It does use Python versions and other
packages (e.g. chromium) supplied by Ubuntu, but that's about it...

> +
> +To run the same against all supported versions of Django (via tox), run:
> +
> +    $ docker-compose run --rm web --quick-tox
> +
> +To run all tests, including Selenium run headlessly, using only the package
> +versions provided by the container, run:

Likewise here.

> +
> +    $ docker-compose run --rm web --test
> +
> +To run the same against all supported versions of Django (via tox), run:
> +
> +    $ docker-compose run --rm web --tox
> +
> +To run all tests in non-headless tests:
"in non-headless mode"?
> +

Once those are sorted:
Reviewed-by: Daniel Axtens <dja at axtens.net>

Regards,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20160831/15948703/attachment.sig>


More information about the Patchwork mailing list