[PATCH v2 09/11] parsemail: Add cover letter parsing

Andy Doan andy.doan at linaro.org
Wed Apr 13 00:09:41 AEST 2016

On 04/11/2016 04:19 PM, Finucane, Stephen wrote:
> On 08 Apr 13:07, Andy Doan wrote:
>> On 04/01/2016 09:57 AM, Stephen Finucane wrote:
>>> Add support for both cover letters and comments on cover letters. This
>>> works using the following heuristics:
>>> * The message contains a '[0/n]' marker tag in the subject
>>> * The message is the root message
>>> Signed-off-by: Stephen Finucane <stephen.finucane at intel.com>
>> Would it be possible to include a test in
>> patchwork/tests/test_patchparser.py for this? Given patch 10 adds
>> another scenario that needs coverage building up a set of tests to
>> assert this logic against seems valuable.
> Test coverage for this entire file is pretty scant. I'm working on a
> series to move most of this functionality to a management command [1]
> and add an '/upload' endpoint. I've taken the opporunity to add a lot
> of tests. I'll try get an RFC out for this week, and if you're happy
> with the amount of tests added then perhaps we can hold off on tests
> right now and add them later in the aforementioned series?

Sounds good.

More information about the Patchwork mailing list