[PATCH v2 00/11] Add cover letter parsing support

Andy Doan andy.doan at linaro.org
Sat Apr 9 04:06:16 AEST 2016


On 04/01/2016 09:57 AM, Stephen Finucane wrote:
> We can now store cover letters, so let's get parsing them. This series
> adds parsing, the bare minimum of UI to display cover letters and some
> general cleanup/bugfixing.

Looks pretty good. I have a general concern about the complexity of the 
parse_mail function. This series hasn't necessarily made it much worse, 
but it hasn't improved either. I'm not sure the base way, may just do a 
separate clean-up patch?

> Damien Lespiau (3):
>    parsemail: Extract prefixes from subject
>    parsemail: Parse series markers e.g. "1/12"
>    parsemail: Extract building the list of mail references
>
> Stephen Finucane (8):
>    views: Integrate cover letter support
>    parsemail: Flatten 'try_decode' method
>    parsemail: Restructure 'parse_content'
>    parsemail: Use consistent 'find_' format
>    parsemail: Be consistent in variable naming
>    parsemail: Add cover letter parsing
>    parsemail: Handle cover letters sent in reply
>    parsemail: Always update Person.email
>
>   patchwork/bin/parsemail.py                    | 278 ++++++++++++++++----------
>   patchwork/templates/patchwork/patch.html      | 239 ----------------------
>   patchwork/templates/patchwork/submission.html | 244 ++++++++++++++++++++++
>   patchwork/templatetags/syntax.py              |   4 +-
>   patchwork/tests/test_detail.py                |  54 +++++
>   patchwork/tests/test_patchparser.py           | 193 +++++++++---------
>   patchwork/tests/utils.py                      |  23 ++-
>   patchwork/urls.py                             |   5 +
>   patchwork/views/cover.py                      |  50 +++++
>   patchwork/views/patch.py                      |  26 ++-
>   10 files changed, 662 insertions(+), 454 deletions(-)
>   delete mode 100644 patchwork/templates/patchwork/patch.html
>   create mode 100644 patchwork/templates/patchwork/submission.html
>   create mode 100644 patchwork/tests/test_detail.py
>   create mode 100644 patchwork/views/cover.py
>



More information about the Patchwork mailing list