[PATCH 1/2] wsgi: Move wsgi file to expected location

Finucane, Stephen stephen.finucane at intel.com
Fri Apr 1 03:16:09 AEDT 2016

On 31 Mar 15:50, Damien Lespiau wrote:
> On Fri, Feb 05, 2016 at 05:35:37PM +0000, Stephen Finucane wrote:
> > Django places a wsgi.py file in the root of each application's
> > directory. Do this, adding a symlink to preserve existing
> > operation for users.
> Even if the commit message mentions a symlink, there isn't one in the
> commit? Seemds like it'd break my migration path at least.
> Also, this commit is not a simple move operation. You are removing the
> addition of a search path for python modules, it'd have been nice to do
> that in a separate patch with an explanation of why it is fine.
> -- 
> Damien

Whoops: so that's a case of judicious use of '--fixup' when a commit
message change was necessary :) I initially set this up as a symlink
but it didn't work, so I generated a 'wsgi.py' file using
'django-admin startproject' and copied that in, keeping only the
header. This is the location where the Django documentation suggests
this file should be placed, and where all automation tooling (be it
Ansible-, Puppet- or Chef-based) seemed to expect to find the file.
This change also makes the PATH unnecessary as the file is now
located in the same directory as the Python modules referenced within.

Hope this explains things,


More information about the Patchwork mailing list