[PATCH 1/3] settings: Move DEFAULT_FROM_EMAIL to the core settings section
stephen.finucane at intel.com
Tue Sep 29 01:01:39 AEST 2015
> > On Mon, Sep 28, 2015 at 02:55:27PM +0100, Finucane, Stephen wrote:
> > > > On Sun, Sep 27, 2015 at 11:07:55PM +0100, Finucane, Stephen wrote:
> > > > > > DEFAULT_FROM_EMAIL is actually a django setting, not a patchwork
> > one.
> > > > > >
> > > > > > Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> > > > >
> > > > > Since this is a purely syntactical change, I'm going to be pedantic
> > > > > and say 'email' should be title-case.
> > > >
> > > > Sigh. These kind of things really aren't very productive.
> > >
> > > Sorry, I know it's time consuming but someone has to do this stuff :(
> > That's where I disagree. I don't think anyone has to nitpick on
> > capitalization of a one word comment.
> To some people it's nitpicking, to others (like me) it's due diligence.
> There's nothing wrong with either viewpoint: it just depends on what side
> of the fence you fall down on. However, I hope a small, semantic change
> like this is a small price to pay for keeping the only guy doing you a
> solid and regularly reviewing your patches happy?
And thanks for doing it, BTW: I do appreciate it :)
> > --
> > Damien
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
More information about the Patchwork