[PATCH] parsemail.py: Avoid skipping patches when parsing

Jose Lamego jose.a.lamego at linux.intel.com
Thu Sep 24 03:38:16 AEST 2015


Hi Damien,

It was a good call on waiting for the test. The v2 patch made the 
"testGitPullWithDiff" to fail. I'm sending separately a v3 patch that 
does the job without undesired effects along with the added test 
"testGitPullWithBranch".

I'm moving the status of this v2 to superseded state.

Thanks,

On 17/09/15 12:04, Damien Lespiau wrote:
> On Tue, Aug 25, 2015 at 11:27:45AM +0100, Damien Lespiau wrote:
>> On Mon, Aug 24, 2015 at 10:20:34AM -0500, Jose Lamego wrote:
>>> Sent patch v2 with missing character. I still need to work on the coverage.
>> Thanks. I believe it's good practice to wait until the test coverage is
>> in place to consider merging the change. When it touches to mail parsing
>> it's fairly easy to do so. Of course, we need to make sure the pull_url
>> still contains something valid.
> Any news on the test case side? I'd rather not pull this in without
> test coverage.
>
> Thanks,
>

-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC



More information about the Patchwork mailing list