[PATCH 04/10] models: Add 'status' model
damien.lespiau at intel.com
Thu Sep 24 03:35:00 AEST 2015
On Wed, Sep 23, 2015 at 06:14:13PM +0100, Finucane, Stephen wrote:
> As such, can you explain what advantages the above proposal would
> introduce over the existing proposal? What does i915 need to do
> differently? If not, I'd like to rework the patch per existing
> comments (i.e. renaming 'Status' to 'Services' or 'Test Status') and
The amount of time needed to run i915 tests is so large that it's
impractical to run them for each patch.
Could you explain the use of the description and context fields? ('A
label to discern status from statuses of other systems' really doesn't
What I'm assuming is that a lot of the "Status" rows will contain the
same information, because it really belongs to a Test object. We're not
just manipulating TestResults but Tests as well, so we need to describe
those objects as well.
Another design question: How to you know with your model that all tests
have been run? That's needed to determine that, indeed, that patch has
passed all the defined tests (a "test" can of course hide a full test
suite, summarized in one entry in patchwork).
> One point regarding the "SeriesTestResult": I had planned to implement
> this as a "lowest common denominator" property. That is, if a patch in
> a series fail, the series is marked as fail etc. What you describe (a
> unique, per series property) is quite a limited use case but its
> behavior could be emulated by only testing the last patch in a series.
> This would require very little "smarts" on your client end.
I don't think introducing special cases is a good thing, eg. how will
you really differenciate the case of a test run on a full series and a
test run on the last patch? you'll have to look at the other patches to
see if a test run was run on them as well?
Patchwork is used by projects with widly different needs, no special
case like that in the code sounds better to me: testing a patch? results
attached to a patch. testing a full series? results attached to a
More information about the Patchwork