[PATCH] models: Resolve issues with Patch.state

Damien Lespiau damien.lespiau at intel.com
Wed Sep 23 22:50:07 AEST 2015


On Tue, Sep 22, 2015 at 04:41:09PM +0100, Damien Lespiau wrote:
> On Tue, Sep 22, 2015 at 04:25:15PM +0100, Finucane, Stephen wrote:
> > > The initial migration introduced in '30bb271' was incomplete: running
> > > 'makemigrations' on the current codebase will produce a migration which
> > > could not be applied cleanly. The reason for this was the non-loading
> > > of initial data for the 'State' model.
> > > 
> > > Fix this issue by only referencing the contents of the 'State' model
> > > when we have to (on save of a 'Patch' object), thus allowing the user
> > > suitable time to apply this initial data.
> > > 
> > > Signed-off-by: Stephen Finucane <stephen.finucane at intel.com>
> > 
> > Damien: are you happy for me to get this merged? I'm calling dibs on
> > this issue unless you've a good reason to go with the other solution?
> > :)
> 
> Sure. 
> 
> Acked-by: Damien Lespiau <damien.lespiau at intel.com>

Picked up for the next pull request.

-- 
Damien


More information about the Patchwork mailing list