[PATCH] tox: Omit tests and manage.py when running coverage tests

Damien Lespiau damien.lespiau at intel.com
Wed Sep 23 02:35:48 AEST 2015


On Tue, Sep 22, 2015 at 05:31:23PM +0100, Finucane, Stephen wrote:
> > On Tue, Sep 22, 2015 at 04:43:17PM +0100, Finucane, Stephen wrote:
> > > > > Having the tests in the coverage reports artifically improve the
> > > > > coverage percentage, because every line in tests is being run.
> > > > >
> > > > > Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> > > >
> > > > Good point.
> > > >
> > > > Reviewed-by: Stephen Finucane <stephen.finucane at intel.com>
> > >
> > > As an aside, still so much work to be done upping coverage :O PEP8
> > > compliance and features first though.
> > 
> > I don't think PEP8 is a priority, it creates more pain than gain at the
> > moment because so many patches are in flight.
> 
> Yes and no. No for files touched by existing submitted patches
> (features and bug fixes >>> style) but yes for all other files.
> Patches that improve code quality are a good thing.

I'm not saying it's a bad thing, but that it does make rebasing patches
harder.

-- 
Damien


More information about the Patchwork mailing list