[PATCH 00/51] Series aware patchwork

Albert ARIBAUD albert.aribaud at gmail.com
Sat Sep 12 05:35:28 AEST 2015

Hi again Damien,

Le Fri, 11 Sep 2015 17:59:57 +0100, Damien Lespiau
<damien.lespiau at intel.com> a écrit :

> On Fri, Sep 11, 2015 at 06:45:31PM +0200, Albert ARIBAUD wrote:
> > Hi Damien,
> > 
> > Le Fri, 11 Sep 2015 16:54:33 +0100, Damien Lespiau
> > <damien.lespiau at intel.com> a écrit :
> > 
> > > Here a few initial patches to make patchwork understand series instead of just
> > > patches. This is not the end of the story, but a minimal-ish start to build
> > > upon. What the series does:
> > > 
> > >   - Parse mails and creates Series objects (what you would expect all mails
> > >     part of the same git send-email are part of the same series)
> > >   - Display the list of series
> > >   - Display details about the series (eg. cover latter + list of patches)
> > >   - As first feature on top, add a way to assign a reviewer to that series
> > 
> > While assigning a series reviewer is a good thing for e.g. syncing
> > patch application, please make it so that one can still individally
> > assign different reviewers to different patches in the series. Such
> > situations can occur in U-Boot, for instance.
> The patch/series split is a bit awkard at times. I made sure to not
> remove any functionality: Everything that is here today stays here. The
> delegate field on patches is still there. It does mean we can have a
> "series" reviewer or a "patch" delegate at the same time.

Great! As you suspected, I'd mistakenly though/feared the series
reviewer would necessarily also be the patches' delegate. If delegation
is unaffected, I'd say adding a reviewer would be a really good thing,
as I personally prefer a series to be applied by a single custodian on
a single tree even though its patches require several other custodians'

> I think it's fine to have both. Projects do things slightly differently
> after all. We could have a mechanism on top to, per-project, hide the
> column(s) that are not useful for that project maybe?

Agreed, reviewer and delegates are all useful.


More information about the Patchwork mailing list