[PATCH v2 3/4] pwclient: rework multi-command help text

Finucane, Stephen stephen.finucane at intel.com
Tue Oct 20 11:56:46 AEDT 2015


> > On 16 Oct 2015 16:39, Brian Norris wrote:
> > > Our --help handling is convoluted and confusing, since we're hacking
> > > around using some of argparse's built-in features (like generating
> > > --help arguments for us). It seems like we were hacking around the
> > > conflict between -h used for hashes and -h used for automatic help
> > > flags. Fortunately, Python's argparse provides us with a
> > > 'conflict_handler' which will resolve these conflicts for us.
> > >
> > > Altogether, this patch means that 'pwclient --help' will not generate a
> > > full recursive print of all subcommand helps (arguably a good thing),
> > > but it provides better automatic formatting of all the supported
> > > subcommands and eliminates some awkward code.
> >
> > forcing people to poke the subcommand help directly is pretty standard
> > in the wider world.  it's not like `git --help` shows every single help
> > screen :).
> >
> > Acked-by: Mike Frysinger <vapier at chromium.org>
> > -mike
> 
> What Mike said. I'll get this merged this week.
> 
> Reviewed-by: Stephen Finucane <stephen.finucane at intel.com>

Merged.


More information about the Patchwork mailing list