[PATCH 3/3] pwclient: basic python3 support

Finucane, Stephen stephen.finucane at intel.com
Sat Oct 17 09:25:12 AEDT 2015


> > From: Mike Frysinger <vapier at chromium.org>
> >
> > This fixes a few random issues to make the script work at least somewhat
> > under python 3:
> > - set the default encoding to utf-8
> > - handle xmlrpclib/xmlrpc.client module renames
> > - handle ConfigParser/configparser module renames
> > - add a unicode() stub for python 3
> > - fix old style class definition w/Filter
> > - use list comprehension instead of map()
> > - drop the unused version= keyword w/argparse
> >
> > The code still runs under python 2 the same as before, and now works for
> > the most part under python 3 -- the handling of encoded content still
> needs
> > some work, but that'll require more surgery, and is best left to another
> > commit after this.
> 
> You're right - it needs a little more work but it's most of the way there.
> Do you plan to do this? I was looking at making use of Django's provided
> 'six' library to solve this issue for the server - we could use it here
> also. Regardless, for this patch
> 
> Reviewed-by: Stephen Finucane <stephen.finucane at intel.com>
> 
> > Signed-off-by: Mike Frysinger <vapier at chromium.org>

Merged.


More information about the Patchwork mailing list