[PATCH] views: patch-list: show the 'Properties' update box for all users

Finucane, Stephen stephen.finucane at intel.com
Sat Oct 17 05:09:46 AEDT 2015


> One more ping? The context changed slightly but it still applies to my
> tree OK. I can resend if needed.
> 
> Thanks,
> Brian

LGTM

Acked-by: Stephen Finucane <stephen.finucane at intel.com>

> On Wed, May 20, 2015 at 11:29:29PM -0700, Brian Norris wrote:
> > On Sat, Nov 22, 2014 at 10:30:06PM -0800, Brian Norris wrote:
> > > Any authenticated user should be able to change the properties of their
> > > own patches from the list view. They can already do so from the patch
> > > view and from pwclient.
> > >
> > > Now, authenticated users can perform 'Change state', 'Delegate to', and
> > > 'Archive' operations on multiple patches at a time (e.g., after
> > > 'select-all' on a bundle, or after selecting a few patches
> > > individually). We'll print an error message to the page for any patches
> > > which can't be updated (e.g., due to ownership).
> > >
> > > This fixes a usability issue that has been reported a few times.
> > >
> > > Signed-off-by: Brian Norris <computersforpeace at gmail.com>
> >
> > Ping? I think this is the right thing to do, and it tested out fine on
> > my machine.
> >
> > Brian
> >
> > > ---
> > >  apps/patchwork/views/__init__.py | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/apps/patchwork/views/__init__.py
> b/apps/patchwork/views/__init__.py
> > > index dfca56dd690c..92b37ca769c3 100644
> > > --- a/apps/patchwork/views/__init__.py
> > > +++ b/apps/patchwork/views/__init__.py
> > > @@ -61,7 +61,7 @@ def generic_list(request, project, view,
> > >          data = request.POST
> > >      user = request.user
> > >      properties_form = None
> > > -    if project.is_editable(user):
> > > +    if user.is_authenticated():
> > >
> > >          # we only pass the post data to the MultiplePatchForm if that
> was
> > >          # the actual form submitted
> > > --
> > > 2.2.0.rc2
> > >
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork


More information about the Patchwork mailing list