[PATCH] parsemail: Don't catch exceptions when saving patches and comments

Damien Lespiau damien.lespiau at intel.com
Fri Oct 9 21:22:54 AEDT 2015


We'd like to know when those operations fail in production so we can at
least inspect what happened through the email send to settings.ADMINS in
main().

Catching those exceptions early prevents that.

Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
---
 patchwork/bin/parsemail.py | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/patchwork/bin/parsemail.py b/patchwork/bin/parsemail.py
index 84ab685..c15564e 100755
--- a/patchwork/bin/parsemail.py
+++ b/patchwork/bin/parsemail.py
@@ -384,10 +384,7 @@ def parse_mail(mail):
         patch.state = get_state(mail.get('X-Patchwork-State', '').strip())
         patch.delegate = get_delegate(
                 mail.get('X-Patchwork-Delegate', '').strip())
-        try:
-            patch.save()
-        except Exception, ex:
-            print str(ex)
+        patch.save()
 
     if comment:
         if save_required:
@@ -397,10 +394,7 @@ def parse_mail(mail):
             comment.patch = patch
         comment.submitter = author
         comment.msgid = msgid
-        try:
-            comment.save()
-        except Exception, ex:
-            print str(ex)
+        comment.save()
 
     return 0
 
-- 
2.1.0



More information about the Patchwork mailing list