[PATCH 00/10] Patchwork Autodelegate patches

Finucane, Stephen stephen.finucane at intel.com
Mon Nov 30 08:42:01 AEDT 2015

On 28 Nov 10:14, Mauro Carvalho Chehab wrote:
> This patch series contain the non-LinuxTV specific patches,
> mainly the auto-delegate patches written by Laurent Pinchart.
> Those got ported to patchwork upstream.
> Please notice that I'm still fighting to finish the migration
> from Django 1.4 to Django 1.7. So, this patch series is not
> fully tested.

I'm pushing Python 3 changes today. I'd be much obliged if you could
test these for me - they're unlikely to break Python 2.7 compatibility
but Python 3.4 could still have some funky bugs that the unit tests
aren't capturing.

> The auto-delegation patches are authored by Laurent, and were
> rebased by me to apply under the upstream branch. They're
> working for a long time at LinuxTV.org, but the rebase might
> cause some troubles on them.
> So, please test.
> There are some patches I wrote myself, to fix some bugs
> and improve a few things:
> - When a patch is delegated, it will add a new meta tag
> (X-Patchwork-Delegate) via xmlrpc. This helps my local scripts
> to detect when a patch is already being handled by somebody else.
> - Added the new delegate table to migrations. The patch
> was actually generated via ./manage makemigrations. Not sure
> if this is correct, as I didn't need to do any migrations related
> to it here ;)
> - Added some prints that helps to debug troubles with parsemail.
> From time to time, we have troubles with non-UTF8 messages on
> different parts of the e-mail. Those prints helps a lot to
> identify when a patch is not handled, giving some explanation
> why it failed.

Good stuff. Unless I hear any objections, I see no issues in testing
and merging these (assuming I don't see anything really broken heh).

I'm pushing Python3 changes for review today and will be focusing on
getting those in first (they're priority for you also, yes?). I also
need to finish reviewing the password change patch [1]. Soon as these
are done this is next in line.

Thanks, Mauro :)


[1] https://patchwork.ozlabs.org/patch/542614/

More information about the Patchwork mailing list