[PATCH] management: Create 'rehash' command

Jeremy Kerr jk at ozlabs.org
Tue Nov 24 17:15:10 AEDT 2015

Hi Stephen,

>> The rehash script, though undocumented and possibly unused at the
>> moment, likely has some value to some users. Howver, it makes more
>> sense to provide this command as a management command like 'retag'.
>> Do this.
>> Signed-off-by: Stephen Finucane <stephen.finucane at intel.com>
> I'm still not sure if this should be converted to a command or just
> deleted. Does anyone use it? It seems like the hash could never really
> get out of date without manual DB modification (in which case you have
> more than one problem) thanks to the 'save' method.

This was useful when the hashes were first introduced, but wouldn't be
used much now. If we did need to change the hashing algorithm, (eg, move
to SHA1, or change which parts of a patch are included in the hashed
text), then it'd be required for that.

I'd say keep it in, since you've already done the work converting it :)



More information about the Patchwork mailing list