[PATCH 0/5] login: add link to password reset, refurbished

[Bernhard Reutner-Fischer]

On 17 October 2015 at 00:57, Finucane, Stephen <stephen.finucane at intel.com> wrote:
> On Wed, Mar 11, 2015 at 10:39:35PM +0100, Bernhard Reutner-Fischer
> wrote:
>> Hi,
>>
>> I am attaching an old patch to add a password-reset knob to the login
>> page. If anyone thinks this is a good idea then it should be
>> thoroughly
>> tested against current django, i do remember that it worked like
>> intended back then.
>>
>> Apparently i never managed to send this one?
>>
>> thanks,
>
> This doesn't apply cleanly to the current HEAD. Mind rebasing it and
> we can get it
> merged/close of the TODO item?

Eh, sneaky mention of TODO ;)
Ok, so i refurbished the "password reset" link, including pretty
patchwork templates instead of the default django admin ones.
Then i wanted to drop it off the docs/TODO list, but alas there was no
such item!
What i found, however, was that somebody asked for being able to change
their email address which sounds like a sane thing to do. Likewise for
your last name (not sure about the first name but it comes for free).

One thing that i wonder is if the patchwork_emailconfirmation is
supposed to be able to hold duplicate user_id/email entries like it
currently does. I do not think this makes sense and should IMHO be
forbidden unless it serves a purpose i cannot see?
Note that the html-ui does not display duplicate entries although they
can be entered in the html-ui and do end up in the database. I wouldn't
allow that.

Some more todos:
* docs/requirements-base.txt could mention psycopg2 along
  MySQL-python==1.2.5, thus patchwork/settings/dev.py should add a
  +        #'ENGINE': 'django.db.backends.postgresql_psycopg2',

thanks,
>
> Cheers,
> Stephen

Bernhard Reutner-Fischer (5):
  login: add link to password reset
  Allow changing primary email address for accounts
  tests/test_user: Remove duplicate test
  TODO: cleanup deprecated unittest aliases
  .gitignore: patchwork/settings/production.py

 .gitignore                                         |  3 ++
 docs/TODO                                          |  3 +-
 patchwork/forms.py                                 | 14 +++++
 patchwork/models.py                                |  3 ++
 patchwork/templates/patchwork/login.html           |  7 ++-
 patchwork/templates/patchwork/profile.html         | 18 ++++++-
 patchwork/templates/patchwork/user-data.html       | 34 ++++++++++++
 patchwork/tests/test_user.py                       | 61 +++++++++++++++++++++-
 patchwork/urls.py                                  | 10 ++++
 patchwork/views/user.py                            | 42 ++++++++++++++-
 .../registration/password_reset_complete.html      |  9 ++++
 templates/registration/password_reset_confirm.html | 51 ++++++++++++++++++
 templates/registration/password_reset_done.html    | 13 +++++
 templates/registration/password_reset_email.html   | 12 +++++
 templates/registration/password_reset_form.html    | 45 ++++++++++++++++
 15 files changed, 320 insertions(+), 5 deletions(-)
 create mode 100644 patchwork/templates/patchwork/user-data.html
 create mode 100644 templates/registration/password_reset_complete.html
 create mode 100644 templates/registration/password_reset_confirm.html
 create mode 100644 templates/registration/password_reset_done.html
 create mode 100644 templates/registration/password_reset_email.html
 create mode 100644 templates/registration/password_reset_form.html

-- 
2.6.2