[PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

Finucane, Stephen stephen.finucane at intel.com
Tue Nov 10 02:33:18 AEDT 2015

> On Mon, Nov 09, 2015 at 02:53:36PM +0000, Finucane, Stephen wrote:
> > Ah, I get the point - I just misinterpreted the line ending character
> > (it's a '\r', but I instinctively saw a '\n'). How about this?
> >
> >     self.stdout.write('%06d/%06d\r' % (i, count), ending='')
> >
> > or this, if you prefer:
> >
> >     self.stdout.write('%06d/%06d' % (i, count), ending='\r')
> >
> > I'm raising this issue just because the Django docs explicitly say to use
> Feel free to rewrite the patch this way if you wish, I don't mind either
> way.

OK, sweet. I'm thinking that asking you this stuff is better than just doing
it because I can make mistakes (I'd likely not have included the `ending`
parameter, for example). Correct me if I'm wrong.

I'll get this merged tonight.


PS: Since we're talking, if you have time to address the remaining comments
on the 'series' series it would be appreciated. I don't want to just do the
rework without you input in case I miss something. It's one of three blockers
for a 2.0 release, along with the Django 1.6 migrations (:() and interface
integration of series (Web UI and XML-RPC, until we get REST sorted). I'm
hoping 2.0 should be widely deployed, so it would be a nice kick to get this
feature in.

More information about the Patchwork mailing list