[PATCH 2/2] retag: Properly display the final count

Finucane, Stephen stephen.finucane at intel.com
Mon Nov 9 13:37:54 AEDT 2015


> i == count cannot happen in the loop as i will vary from 0 to count - 1.
> 
> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> ---
>  patchwork/management/commands/retag.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/patchwork/management/commands/retag.py
> b/patchwork/management/commands/retag.py
> index e67d099..cb95398 100644
> --- a/patchwork/management/commands/retag.py
> +++ b/patchwork/management/commands/retag.py
> @@ -38,7 +38,8 @@ class Command(BaseCommand):
> 
>          for i, patch in enumerate(query.iterator()):
>              patch.refresh_tag_counts()
> -            if (i % 10) == 0 or i == count:
> +            if (i % 10) == 0:

What happens if count == 11?
 
>                  sys.stdout.write('%06d/%06d\r' % (i, count))
>                  sys.stdout.flush()
> +        sys.stdout.write('%06d/%06d\r' % (count, count))
>          sys.stdout.write('\ndone\n')
> --
> 2.4.3
> 
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork


More information about the Patchwork mailing list