[PATCH 04/10] models: Add 'status' model

Finucane, Stephen stephen.finucane at intel.com
Wed Jul 29 19:58:11 AEST 2015

> Hi Stephen,
> Thanks for your good work.
> 2015-07-29 09:58, Stephen Finucane:
> > +class Status(models.Model):
> > +    """Status for a patch.
> > +
> > +    Statuses define a state for patches. This is useful, for example,
> > +    when using a continuous integration (CI) system to test patches.
> > +    """
> There is already "class State" associated to "class Patch".
> Don't you think TestStatus would be a better name?

I've discussed this with a few folks already. The 'Status.state' naming is inconvenient, but I can't think of a better word to represent this. As for the whole model, I think we shouldn't necessarily restrict this to test results: you could have a license check job, for example. I did consider renaming the model 'services' (this is the terminology the rather sweet 'review.ninja' app uses) but I think 'status' is still perfectly suitable TBH. Thoughts?


More information about the Patchwork mailing list