[PATCH] Highlight patches with Acked/Reviewed/Tested tags

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Jul 20 19:30:59 AEST 2015

A little while ago, accounting of the number of Acked-by, Reviewed-by
and Tested-by tags was added to patchwork. The count of such tags per
patch is shown in the "A / R / T" column.

However, since the values are shown for all patches regardless of
whether they are zero or not, it makes it not very easy to spot the
patches that have at least one Acked-by, Tested-by or Reviewed-by tag.

Therefore, this patch proposes to replace a count of "0" by a "-". So
patches with no tags will have "- - -" in their A/R/T column, and
patches with some tags may get "1 - 1" for example.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Patch has not been tested: I don't have a working patchwork
installation, and it's a bit annoying to do all the installation
process for such a simple patch.
 patchwork/templatetags/patch.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/patchwork/templatetags/patch.py b/patchwork/templatetags/patch.py
index ea23ebd..7bbcf14 100644
--- a/patchwork/templatetags/patch.py
+++ b/patchwork/templatetags/patch.py
@@ -72,7 +72,10 @@ def patch_tags(patch):
     for tag in patch.project.tags:
         count = getattr(patch, tag.attr_name)
         titles.append('%d %s' % (count, tag.name))
-        counts.append(str(count))
+        if count == 0:
+            counts.append("-")
+        else:
+            counts.append(str(count))
     return mark_safe('<span title="%s">%s</span>' % (
             ' / '.join(titles),
             ' '.join(counts)))

More information about the Patchwork mailing list