Broken parsing of UTF-8 chars
Rafał Miłecki
zajec5 at gmail.com
Tue Jan 20 02:40:42 AEDT 2015
Hi,
my name includes some out-of-ASCII chars and it seems patchwork can't
really handle them. It seems to happen no matter if I send something
using git send-email or Gmail web interface.
I've collected few examples:
1) [Gmail] My ACK to some b43legacy patch (5575891.txt):
https://patchwork.kernel.org/patch/5575891/
My name from "From" header was malformed into Rafał Miłecki
My name from content (Acked-by) was malformed into Rafa? Mi?ecki
2) [Gmail] My ACK to some bcma patch (5545021.txt):
https://patchwork.kernel.org/patch/5545021/
Same as above.
3) [git] bcma: clean bus initialization code (5650221.txt)
https://patchwork.kernel.org/patch/5650221/
4) [git] bcma: use standard bus scanning during early register (5655171.txt)
https://patchwork.kernel.org/patch/5655171/
It causes real problems for me, because maintainers usually download
patches as mbox-es and applies them. It results in my name being
malformed in git repository:
https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=d0c102f70aec07eaeb23de30892f425e4c5f6045
https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=d0f66df5392aaf771c647436e32849e3a4c4e3ff
Could you fix this, please?
--
Rafał
-------------- next part --------------
MIME-Version: 1.0
Received: by 10.107.4.79 with HTTP; Tue, 6 Jan 2015 10:19:52 -0800 (PST)
In-Reply-To: <1420567175-17323-1-git-send-email-rickard_strandqvist at spectrumdigital.se>
References: <1420567175-17323-1-git-send-email-rickard_strandqvist at spectrumdigital.se>
Date: Tue, 6 Jan 2015 19:19:52 +0100
Delivered-To: zajec5 at gmail.com
Message-ID: <CACna6ryS_+eYi3ODXMngCxwoe8JLuWQyaCNNmhJFHM+g7H_Xzw at mail.gmail.com>
Subject: Re: [PATCH] b43legacy: Remove unused function
From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5 at gmail.com>
To: Rickard Strandqvist <rickard_strandqvist at spectrumdigital.se>
Cc: Larry Finger <Larry.Finger at lwfinger.net>, Stefano Brivio <stefano.brivio at polimi.it>,
Network Development <netdev at vger.kernel.org>,
"linux-wireless at vger.kernel.org" <linux-wireless at vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel at vger.kernel.org>, b43-dev <b43-dev at lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On 6 January 2015 at 18:59, Rickard Strandqvist
<rickard_strandqvist at spectrumdigital.se> wrote:
> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere=
.
>
> This was partially found by using a static code analysis program called c=
ppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist at spectrumdigital.s=
e>
Acked-by: Rafa=C5=82 Mi=C5=82ecki <zajec5 at gmail.com>
-------------- next part --------------
MIME-Version: 1.0
Received: by 10.107.4.79 with HTTP; Sat, 27 Dec 2014 15:44:20 -0800 (PST)
In-Reply-To: <1419708268-14114-1-git-send-email-oscar.forner.martinez at gmail.com>
References: <1419708268-14114-1-git-send-email-oscar.forner.martinez at gmail.com>
Date: Sun, 28 Dec 2014 00:44:20 +0100
Delivered-To: zajec5 at gmail.com
Message-ID: <CACna6rz4ue2PFQR-=nKxmCJSw9O8pKU=S7LqxA68OY1D0obvKg at mail.gmail.com>
Subject: Re: [PATCH] bcma: fix three coding style issues, more than 80
characters per line
From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5 at gmail.com>
To: Oscar Forner Martinez <oscar.forner.martinez at gmail.com>
Cc: "linux-wireless at vger.kernel.org" <linux-wireless at vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel at vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On 27 December 2014 at 20:24, Oscar Forner Martinez
<oscar.forner.martinez at gmail.com> wrote:
> Three lines with more than 80 characters per line have been split in seve=
ral lines.
>
> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez at gmail.com>
Acked-by: Rafa=C5=82 Mi=C5=82ecki <zajec5 at gmail.com>
Kalle: will you pick this patch?
-------------- next part --------------
Return-Path: <zajec5 at gmail.com>
Received: from linux-tdhb.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233])
by mx.google.com with ESMTPSA id x2sm7332166wjx.9.2015.01.16.11.59.51
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Fri, 16 Jan 2015 11:59:53 -0800 (PST)
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5 at gmail.com>
To: Kalle Valo <kvalo at codeaurora.org>,
linux-wireless at vger.kernel.org
Cc: Hauke Mehrtens <hauke at hauke-m.de>,
=?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5 at gmail.com>
Subject: [PATCH V2] bcma: clean bus initialization code
Date: Fri, 16 Jan 2015 20:59:39 +0100
Message-Id: <1421438379-26211-1-git-send-email-zajec5 at gmail.com>
X-Mailer: git-send-email 1.8.4.5
In-Reply-To: <1421435929-21499-1-git-send-email-zajec5 at gmail.com>
References: <1421435929-21499-1-git-send-email-zajec5 at gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This moves main bus init code to the main.c and renames old function to
make its purpose clear.
Thanks to this change we'll also be able to separate scanning from
registration (and support PCIe Gen 2 devices) in the future.
Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
---
V2: Fix typo (s/initialiation/initialization/)
Put bcma_detect_chip earlier in .h to match order in .c
---
drivers/bcma/bcma_private.h | 3 ++-
drivers/bcma/main.c | 16 ++++++++++++----
drivers/bcma/scan.c | 5 +----
3 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/bcma/bcma_private.h b/drivers/bcma/bcma_private.h
index 314ae40..59422b5 100644
--- a/drivers/bcma/bcma_private.h
+++ b/drivers/bcma/bcma_private.h
@@ -25,6 +25,7 @@ struct bcma_bus;
bool bcma_wait_value(struct bcma_device *core, u16 reg, u32 mask, u32 value,
int timeout);
void bcma_prepare_core(struct bcma_bus *bus, struct bcma_device *core);
+void bcma_init_bus(struct bcma_bus *bus);
int bcma_bus_register(struct bcma_bus *bus);
void bcma_bus_unregister(struct bcma_bus *bus);
int __init bcma_bus_early_register(struct bcma_bus *bus,
@@ -36,11 +37,11 @@ int bcma_bus_resume(struct bcma_bus *bus);
#endif
/* scan.c */
+void bcma_detect_chip(struct bcma_bus *bus);
int bcma_bus_scan(struct bcma_bus *bus);
int __init bcma_bus_scan_early(struct bcma_bus *bus,
struct bcma_device_id *match,
struct bcma_device *core);
-void bcma_init_bus(struct bcma_bus *bus);
/* sprom.c */
int bcma_sprom_get(struct bcma_bus *bus);
diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
index 534e133..c166d44 100644
--- a/drivers/bcma/main.c
+++ b/drivers/bcma/main.c
@@ -268,6 +268,18 @@ void bcma_prepare_core(struct bcma_bus *bus, struct bcma_device *core)
}
}
+void bcma_init_bus(struct bcma_bus *bus)
+{
+ mutex_lock(&bcma_buses_mutex);
+ bus->num = bcma_bus_next_num++;
+ mutex_unlock(&bcma_buses_mutex);
+
+ INIT_LIST_HEAD(&bus->cores);
+ bus->nr_cores = 0;
+
+ bcma_detect_chip(bus);
+}
+
static void bcma_register_core(struct bcma_bus *bus, struct bcma_device *core)
{
int err;
@@ -369,10 +381,6 @@ int bcma_bus_register(struct bcma_bus *bus)
int err;
struct bcma_device *core;
- mutex_lock(&bcma_buses_mutex);
- bus->num = bcma_bus_next_num++;
- mutex_unlock(&bcma_buses_mutex);
-
/* Scan for devices (cores) */
err = bcma_bus_scan(bus);
if (err) {
diff --git a/drivers/bcma/scan.c b/drivers/bcma/scan.c
index 9175207..5328ee5 100644
--- a/drivers/bcma/scan.c
+++ b/drivers/bcma/scan.c
@@ -435,15 +435,12 @@ static int bcma_get_next_core(struct bcma_bus *bus, u32 __iomem **eromptr,
return 0;
}
-void bcma_init_bus(struct bcma_bus *bus)
+void bcma_detect_chip(struct bcma_bus *bus)
{
s32 tmp;
struct bcma_chipinfo *chipinfo = &(bus->chipinfo);
char chip_id[8];
- INIT_LIST_HEAD(&bus->cores);
- bus->nr_cores = 0;
-
bcma_scan_switch_core(bus, BCMA_ADDR_BASE);
tmp = bcma_scan_read32(bus, 0, BCMA_CC_ID);
--
1.8.4.5
-------------- next part --------------
Return-Path: <zajec5 at gmail.com>
Received: from linux-tdhb.lan (static-91-227-21-4.devs.futuro.pl. [91.227.21.4])
by mx.google.com with ESMTPSA id bb2sm4449920wjc.43.2015.01.18.23.30.50
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Sun, 18 Jan 2015 23:30:51 -0800 (PST)
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5 at gmail.com>
To: Kalle Valo <kvalo at codeaurora.org>,
linux-wireless at vger.kernel.org
Cc: Hauke Mehrtens <hauke at hauke-m.de>,
=?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5 at gmail.com>
Subject: [PATCH V2] bcma: use standard bus scanning during early register
Date: Mon, 19 Jan 2015 08:30:30 +0100
Message-Id: <1421652630-26665-1-git-send-email-zajec5 at gmail.com>
X-Mailer: git-send-email 1.8.4.5
In-Reply-To: <1421442493-32133-1-git-send-email-zajec5 at gmail.com>
References: <1421442493-32133-1-git-send-email-zajec5 at gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Starting with kernel 3.19-rc1 early registration of bcma on MIPS is done
a bit later, with memory allocator available. This allows us to simplify
code by using standard bus scanning method.
Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
---
V2: Add comment about skipping scanning for the 2nd time
---
drivers/bcma/bcma_private.h | 7 +----
drivers/bcma/host_soc.c | 2 +-
drivers/bcma/main.c | 33 +++++++----------------
drivers/bcma/scan.c | 62 +++----------------------------------------
include/linux/bcma/bcma_soc.h | 2 --
5 files changed, 15 insertions(+), 91 deletions(-)
diff --git a/drivers/bcma/bcma_private.h b/drivers/bcma/bcma_private.h
index 59422b5..3f314c9 100644
--- a/drivers/bcma/bcma_private.h
+++ b/drivers/bcma/bcma_private.h
@@ -28,9 +28,7 @@ void bcma_prepare_core(struct bcma_bus *bus, struct bcma_device *core);
void bcma_init_bus(struct bcma_bus *bus);
int bcma_bus_register(struct bcma_bus *bus);
void bcma_bus_unregister(struct bcma_bus *bus);
-int __init bcma_bus_early_register(struct bcma_bus *bus,
- struct bcma_device *core_cc,
- struct bcma_device *core_mips);
+int __init bcma_bus_early_register(struct bcma_bus *bus);
#ifdef CONFIG_PM
int bcma_bus_suspend(struct bcma_bus *bus);
int bcma_bus_resume(struct bcma_bus *bus);
@@ -39,9 +37,6 @@ int bcma_bus_resume(struct bcma_bus *bus);
/* scan.c */
void bcma_detect_chip(struct bcma_bus *bus);
int bcma_bus_scan(struct bcma_bus *bus);
-int __init bcma_bus_scan_early(struct bcma_bus *bus,
- struct bcma_device_id *match,
- struct bcma_device *core);
/* sprom.c */
int bcma_sprom_get(struct bcma_bus *bus);
diff --git a/drivers/bcma/host_soc.c b/drivers/bcma/host_soc.c
index 335cbcf..2dce347 100644
--- a/drivers/bcma/host_soc.c
+++ b/drivers/bcma/host_soc.c
@@ -193,7 +193,7 @@ int __init bcma_host_soc_init(struct bcma_soc *soc)
int err;
/* Scan bus and initialize it */
- err = bcma_bus_early_register(bus, &soc->core_cc, &soc->core_mips);
+ err = bcma_bus_early_register(bus);
if (err)
iounmap(bus->mmio);
diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
index c166d44..c3c5e0a 100644
--- a/drivers/bcma/main.c
+++ b/drivers/bcma/main.c
@@ -489,35 +489,20 @@ void bcma_bus_unregister(struct bcma_bus *bus)
kfree(cores[0]);
}
-int __init bcma_bus_early_register(struct bcma_bus *bus,
- struct bcma_device *core_cc,
- struct bcma_device *core_mips)
+/*
+ * This is a special version of bus registration function designed for SoCs.
+ * It scans bus and performs basic initialization of main cores only.
+ * Please note it requires memory allocation, however it won't try to sleep.
+ */
+int __init bcma_bus_early_register(struct bcma_bus *bus)
{
int err;
struct bcma_device *core;
- struct bcma_device_id match;
-
- match.manuf = BCMA_MANUF_BCM;
- match.id = bcma_cc_core_id(bus);
- match.class = BCMA_CL_SIM;
- match.rev = BCMA_ANY_REV;
-
- /* Scan for chip common core */
- err = bcma_bus_scan_early(bus, &match, core_cc);
- if (err) {
- bcma_err(bus, "Failed to scan for common core: %d\n", err);
- return -1;
- }
-
- match.manuf = BCMA_MANUF_MIPS;
- match.id = BCMA_CORE_MIPS_74K;
- match.class = BCMA_CL_SIM;
- match.rev = BCMA_ANY_REV;
- /* Scan for mips core */
- err = bcma_bus_scan_early(bus, &match, core_mips);
+ /* Scan for devices (cores) */
+ err = bcma_bus_scan(bus);
if (err) {
- bcma_err(bus, "Failed to scan for mips core: %d\n", err);
+ bcma_err(bus, "Failed to scan bus: %d\n", err);
return -1;
}
diff --git a/drivers/bcma/scan.c b/drivers/bcma/scan.c
index 5328ee5..df806b9 100644
--- a/drivers/bcma/scan.c
+++ b/drivers/bcma/scan.c
@@ -461,6 +461,10 @@ int bcma_bus_scan(struct bcma_bus *bus)
int err, core_num = 0;
+ /* Skip if bus was already scanned (e.g. during early register) */
+ if (bus->nr_cores)
+ return 0;
+
erombase = bcma_scan_read32(bus, 0, BCMA_CC_EROM);
if (bus->hosttype == BCMA_HOSTTYPE_SOC) {
eromptr = ioremap_nocache(erombase, BCMA_CORE_SIZE);
@@ -519,61 +523,3 @@ out:
return err;
}
-
-int __init bcma_bus_scan_early(struct bcma_bus *bus,
- struct bcma_device_id *match,
- struct bcma_device *core)
-{
- u32 erombase;
- u32 __iomem *eromptr, *eromend;
-
- int err = -ENODEV;
- int core_num = 0;
-
- erombase = bcma_scan_read32(bus, 0, BCMA_CC_EROM);
- if (bus->hosttype == BCMA_HOSTTYPE_SOC) {
- eromptr = ioremap_nocache(erombase, BCMA_CORE_SIZE);
- if (!eromptr)
- return -ENOMEM;
- } else {
- eromptr = bus->mmio;
- }
-
- eromend = eromptr + BCMA_CORE_SIZE / sizeof(u32);
-
- bcma_scan_switch_core(bus, erombase);
-
- while (eromptr < eromend) {
- memset(core, 0, sizeof(*core));
- INIT_LIST_HEAD(&core->list);
- core->bus = bus;
-
- err = bcma_get_next_core(bus, &eromptr, match, core_num, core);
- if (err == -ENODEV) {
- core_num++;
- continue;
- } else if (err == -ENXIO)
- continue;
- else if (err == -ESPIPE)
- break;
- else if (err < 0)
- goto out;
-
- core->core_index = core_num++;
- bus->nr_cores++;
- bcma_info(bus, "Core %d found: %s (manuf 0x%03X, id 0x%03X, rev 0x%02X, class 0x%X)\n",
- core->core_index, bcma_device_name(&core->id),
- core->id.manuf, core->id.id, core->id.rev,
- core->id.class);
-
- list_add_tail(&core->list, &bus->cores);
- err = 0;
- break;
- }
-
-out:
- if (bus->hosttype == BCMA_HOSTTYPE_SOC)
- iounmap(eromptr);
-
- return err;
-}
diff --git a/include/linux/bcma/bcma_soc.h b/include/linux/bcma/bcma_soc.h
index f24d245..1b5fc0c 100644
--- a/include/linux/bcma/bcma_soc.h
+++ b/include/linux/bcma/bcma_soc.h
@@ -5,8 +5,6 @@
struct bcma_soc {
struct bcma_bus bus;
- struct bcma_device core_cc;
- struct bcma_device core_mips;
};
int __init bcma_host_soc_register(struct bcma_soc *soc);
--
1.8.4.5
More information about the Patchwork
mailing list