[PATCH 5/9] py3: "Modernize" code base

Finucane, Stephen stephen.finucane at intel.com
Fri Dec 11 07:20:18 AEDT 2015


On 29 Nov 22:10, Stephen Finucane wrote:
> Run code through the 'modernize' application to fix Python 3
> compatibility while also retaining Python 2 backwards compatibility.
> 
> There are some key changes made to the autogenerated code:
> 
> * Don't wrap 'items()' in 'list' for for loops - it's not necessary
> * Don't wrap 'keys()' in 'list' - just drop 'keys()'
> * Use Django's version of six rather than the upstream one
> 
> Many of the issues found are based upon the changed definitions of the
> map, keys and items functions, along with the removal of the iteritems
> function and reduce keyword.
> 
> Signed-off-by: Stephen Finucane <stephen.finucane at intel.com>

I've been using this for over two weeks without issue. Happy to merge.


More information about the Patchwork mailing list