[PATCH 49/51] filters: Submit the form when <Enter> is pressed on a closed submitter field

Damien Lespiau damien.lespiau at intel.com
Tue Aug 25 04:23:38 AEST 2015


<Enter> when an element of the form is focused should submit the form.
Before this patch, when <Enter> was pressed on the submitter button,
nothing would happen.

So, we tweak our <Enter> handling on the submitter input a bit more:
<Enter> can be used to select the submitter from the autocompletion
list, but, when pressed a second time (ie. when the autocompletion
option has be selected and the dropdown isn't shown), we submit the
form.

Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
---
 patchwork/templates/patchwork/filters.html | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/patchwork/templates/patchwork/filters.html b/patchwork/templates/patchwork/filters.html
index 1af943b..fe0c9b8 100644
--- a/patchwork/templates/patchwork/filters.html
+++ b/patchwork/templates/patchwork/filters.html
@@ -27,9 +27,11 @@ Selectize.define('enter_key_submit', function (options) {
         var original = self.onKeyDown;
 
         return function (e) {
+            var wasOpened = this.isOpen;
             original.apply(this, arguments);
 
-            if (e.keyCode === 13 && this.$control_input.val() != '' )
+            if (e.keyCode === 13 &&
+                (this.$control_input.val() != '' || !wasOpened))
                 self.trigger('submit');
         };
     })();
-- 
2.1.0



More information about the Patchwork mailing list