[PATCH 25/46] filters: Rewrite the submitter autocompletion code

Damien Lespiau damien.lespiau at intel.com
Tue Aug 25 01:00:22 AEST 2015

On Mon, Aug 24, 2015 at 03:45:56PM +0100, Peter Maydell wrote:
> On 10 November 2014 at 13:01, Jeremy Kerr <jk at ozlabs.org> wrote:
> > Hi Damien,
> >> A slight change in behaviour is that we now don't allow "free form"
> >> submitter search, ie we need a valid completion to search with that
> >> specific person (through its primary key). I didn't remove the backend
> >> logic that allows the "free form" mechanism, but maybe we should.
> >
> >
> > Originally, I've included that for the case where we have no client-side
> > javascript, and hence no completion.
> I use the free-form search all the time, because the autocomplete
> results often seem to be rubbish (they don't always include what I
> actually want and often include a lot of extra results that are
> nothing to do with what I've typed). Luckily the autocomplete also
> takes a second or so to kick in, so if you type fast enough into the
> box and hit return you can get the free-text search. So I'd be sad
> if the freetext search disappeared...

Oh well, that's two people already. I guess I'll see what I can do to
preserve this behaviour.

I still think that's really the widget being broken and maybe even a
case of https://xkcd.com/1172/ :). It's true that having to wait for the
suggestions can be annoying and the free search would "solve" that part.
The rest like "extra results that are nothing to do with what I typed"
are plain bugs though! We shouldn't keep existing behaviours just
because they allow to work around bugs.


More information about the Patchwork mailing list