[PATCH] parsemail.py: Avoid skipping patches when parsing

Damien Lespiau damien.lespiau at intel.com
Fri Aug 21 01:10:08 AEST 2015


On Mon, Aug 17, 2015 at 09:46:06AM -0500, Jose Lamego wrote:
> Avoids some email patch notifications to be
> wrongly skipped when the commit's descriptor string
> includes or is missing a character/space from the
> expected format.
> An example of a missed email patch notification
> can be found in [1].
> 
> [1] http://patchwork.openembedded.org/patch/96385/
> 
> Signed-off-by: Jose Lamego <jose.a.lamego at linux.intel.com>
> 
> ---
>  patchwork/bin/parsemail.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/patchwork/bin/parsemail.py b/patchwork/bin/parsemail.py
> index f2b10bd..902e554 100755
> --- a/patchwork/bin/parsemail.py
> +++ b/patchwork/bin/parsemail.py
> @@ -141,8 +141,8 @@ def mail_headers(mail):
>  
>  def find_pull_request(content):
>      git_re = re.compile('^The following changes since commit.*' +
> -                        '^are available in the git repository at:\n'
> -                        '^\s*([\S]+://[^\n]+)$',
> +                        '^are available in the git repository at.*:

The string literal isn't closed making it unlikely that patch is working :)

Running the unit tests caught it:

  ImportError: Failed to import test module: patchwork.tests.test_patchparser
  Traceback (most recent call last):
    File "/usr/lib/python2.7/unittest/loader.py", line 254, in _find_tests
      module = self._get_module_from_name(name)
    File "/usr/lib/python2.7/unittest/loader.py", line 232, in _get_module_from_name
      __import__(name)
    File "/var/lib/jenkins/jobs/patchwork-github/workspace/patchwork/tests/test_patchparser.py", line 40, in <module>
      from patchwork.bin.parsemail import find_content, find_author, find_project, \
    File "/var/lib/jenkins/jobs/patchwork-github/workspace/patchwork/bin/parsemail.py", line 144
      '^are available in the git repository at.*:
                                                ^
  SyntaxError: EOL while scanning string literal

-- 
Damien


More information about the Patchwork mailing list