Web view broken for patch

Brian Norris computersforpeace at gmail.com
Mon Nov 24 18:06:11 AEDT 2014

On Sun, Nov 23, 2014 at 09:34:34AM +0100, Wolfram Sang wrote:
> displaying this patch is broken in the web interface:
> http://patchwork.ozlabs.org/patch/413335/
> Only one hunk is displayed as a patch, the other hunk as a comment.
> Would be great if somebody could have a look.

The patch is malformed (line-wrapped). Particularly, all the lines
beginning with '@@' are wrapped prematurely, like this:

@@ -885,7 +885,14 @@ static void i2c_pxa_irq_txempty(struct pxa_i2c 
*i2c, u32 isr)

I assume Patchwork doesn't have enough magic to determine the hunks
properly in this case. (And FWIW, git compalins about a corrupt patch
with 'git apply'.)


More information about the Patchwork mailing list