[PATCH] views: patch-list: show the 'Properties' update box for all users

Brian Norris computersforpeace at gmail.com
Sun Nov 23 17:30:06 AEDT 2014


Any authenticated user should be able to change the properties of their
own patches from the list view. They can already do so from the patch
view and from pwclient.

Now, authenticated users can perform 'Change state', 'Delegate to', and
'Archive' operations on multiple patches at a time (e.g., after
'select-all' on a bundle, or after selecting a few patches
individually). We'll print an error message to the page for any patches
which can't be updated (e.g., due to ownership).

This fixes a usability issue that has been reported a few times.

Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 apps/patchwork/views/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/patchwork/views/__init__.py b/apps/patchwork/views/__init__.py
index dfca56dd690c..92b37ca769c3 100644
--- a/apps/patchwork/views/__init__.py
+++ b/apps/patchwork/views/__init__.py
@@ -61,7 +61,7 @@ def generic_list(request, project, view,
         data = request.POST
     user = request.user
     properties_form = None
-    if project.is_editable(user):
+    if user.is_authenticated():
 
         # we only pass the post data to the MultiplePatchForm if that was
         # the actual form submitted
-- 
2.2.0.rc2



More information about the Patchwork mailing list