[RFC] parsemail.py: Don't search for patches in replies

Mauro Carvalho Chehab mchehab at infradead.org
Sat Feb 8 10:13:15 EST 2014

Em Fri, 7 Feb 2014 14:52:52 -0800
Markus Mayer <markus.mayer at linaro.org> escreveu:

> On 7 February 2014 14:37, Wolfram Sang <wsa at the-dreams.de> wrote:
> > On Fri, Feb 07, 2014 at 11:06:39PM +0100, Carl-Daniel Hailfinger wrote:
> >> Am 06.02.2014 23:49 schrieb Markus Mayer:
> >> > Make sure we don't attempt to search for a patch in a reply e-mail.
> >> > There are MUAs out there who leave the quoted e-mail intact without
> >> > prepending quote characters such as ">" at the beginning of each line.
> >> >
> >> > When that happens, parse_patch() thinks the quoted patch is new. The
> >> > result are multiple database entries containing the same patch (one for
> >> > each such reply) when one would really expect a consolidated thread
> >> > containing the entire discussion and only one copy of the patch.
> >> >
> >> > Signed-off-by: Markus Mayer <markus.mayer at linaro.org>
> >>
> >> AFAICS this will cause loss of patches which are sent as replies.
> >
> > +1. This approach will cause more pain than gain. Move those users away
> > from Outlook, would be my recommendation.

+1. The replied patches are generally better versions than the
original one.

> Have you ever worked for a 10,000+ employee organization?
> And no, I don't particularly like this solution, either. But I
> couldn't come up with a better one.

This has nothing to do with the number of employees, but if they're
using or not the right tools.

If contributors are using some MUA that adds space/tabs/whatever instead
of ">", the patches will already be mangled by such MUA.

Btw, at Kernel, there are thousands of contributions, and I get
a way more patches with whitespaces mangled than bad replies that
re-add the same patch.

Still, I even prefer to receive whitespace mangled patches,
as I can easily fix trivial whitespace mangling, or otherwise
reply to the author to fix it for me. This is a way better than
losing a good patch.



More information about the Patchwork mailing list