[RFC] parsemail.py: Don't search for patches in replies
c-d.hailfinger.devel.2006 at gmx.net
Sat Feb 8 09:06:39 EST 2014
Am 06.02.2014 23:49 schrieb Markus Mayer:
> Make sure we don't attempt to search for a patch in a reply e-mail.
> There are MUAs out there who leave the quoted e-mail intact without
> prepending quote characters such as ">" at the beginning of each line.
> When that happens, parse_patch() thinks the quoted patch is new. The
> result are multiple database entries containing the same patch (one for
> each such reply) when one would really expect a consolidated thread
> containing the entire discussion and only one copy of the patch.
> Signed-off-by: Markus Mayer <markus.mayer at linaro.org>
AFAICS this will cause loss of patches which are sent as replies. This
would totally kill roughly 90% of the second iterations of patches sent
to the flashrom mailing list (and the flashrom project uses patchwork
heavily). A reply mail to a patch may contain a counterproposal. After
all, email has the Re: subject prefix exactly to denote replies, and of
course replies can contain patches. Manually removing Re: from the
subject removes the visual clue that some mail is a reply to another
one. You wouldn't strip the Re: from normal reply mails, and why would
you strip the Re: from replies containing patches?
More information about the Patchwork