Delegate Vs Reviewer

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Dec 2 08:55:35 AEDT 2014


Hi Mauro,

On Wednesday 26 November 2014 10:14:19 Mauro Carvalho Chehab wrote:
> Em Wed, 26 Nov 2014 13:42:21 +0800 Jeremy Kerr escreveu:
> > > On Mon, Nov 24, 2014 at 05:35:11PM +0000, Damien Lespiau wrote:
> > >> I'd like to be able to assign reviewers to patches. That seems very
> > >> close to what a delegate is today. Would anyone have objections if I
> > >> just use Delegate as Reviewer?
> > > 
> > > I'm honestly not sure what Delegate is intended for. It seems like its
> > > purpose is open to your interpretation.
> > 
> > One example: on the powerpc list, we have an overall maintainer, and
> > several sub-maintainers, who are generally responsible for their own
> > subsystem or set of hardware.
> > 
> > If a patch for one of the sub-maintiners' areas appears, it can be
> > delegated to the appropriate person to review, test, and/or merge. The
> > change is then included in the next merge-request from the
> > sub-maintainer to the main maintainer.
> 
> We do the same at the media subsystem. Laurent even wrote some patches
> for patchwork to do patch auto-delegation based on the paths inside
> the diffstat, using regex expressions.
> 
> Not sure if he sent those patches upstream.

I haven't. The code is available at git://git.ideasonboard.org/patchwork.git 
if anyone is interested. I'm afraid I won't have time to work on it in the 
near future.

> > In this case, patch review is only one of the tasks of the delegate.

-- 
Regards,

Laurent Pinchart



More information about the Patchwork mailing list