[PATCH] models: Don't munge the 'From' field of patches

Wolfram Sang wsa at the-dreams.de
Thu Sep 26 18:45:14 EST 2013

On Mon, Feb 18, 2013 at 03:03:33PM -0800, Doug Anderson wrote:
> Jeremy,
> On Fri, Feb 15, 2013 at 9:05 PM, Jeremy Kerr <jk at ozlabs.org> wrote:
> >> The biggest problem is that patchwork saves the "official" name for an
> >> email address the first time it sees an email from them.  If that name
> >> is wrong (or was missing) patchwork will be confused even if future
> >> emails from this person are fixed.  There are similar problems if a
> >> user changes his/her name (get married?).
> >>
> >> It seems better to just have each patch report the actual "From" that
> >> was used to send that patch.  We'll still return the submitter in
> >> 'X-Patchwork-Submitter' just in case someone wants it.
> >
> > This change will cause the mbox download to show a different name than the
> > web UI, which may also be confusing. How about we store the name in the
> > Patch model (if it differs from the Person object) from the From header?
> In which part of the web UI?  I played with this and the "Headers"
> still shows the proper (un-munged) From address.  Certainly the
> "Submitter" at the top still shows the official patchwork idea of what
> the person's name is but I'm not convinced that's a bad thing.
> Overall patchwork has the concept of what the official name of a
> submitter in several places (replies, the "Filters" UI, etc).  Having
> the UI show a different name than the "From" mail header is not so
> different than seeing a "reply" have a different name than the
> "Acked-by" like that the reply contains...
> Anyway, I'm happy to give your proposal a shot if you want.  Let me know...

Ping. Still an issue: http://patchwork.ozlabs.org/patch/277644/



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20130926/73af785d/attachment.sig>

More information about the Patchwork mailing list