[PATCH 1/2] tests/mboxviews: add test for correct From header
Andreas Bießmann
andreas.devel at googlemail.com
Fri May 10 20:44:25 EST 2013
Currently we produce corrupted 'From' header in mbox output when senders name
contains non ASCII characters. Provide a test to show this issue.
Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com>
---
apps/patchwork/tests/mboxviews.py | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/apps/patchwork/tests/mboxviews.py b/apps/patchwork/tests/mboxviews.py
index a3c10cf..07513c2 100644
--- a/apps/patchwork/tests/mboxviews.py
+++ b/apps/patchwork/tests/mboxviews.py
@@ -1,3 +1,5 @@
+# vim: set fileencoding=utf-8 :
+#
# Patchwork - automated patch tracking system
# Copyright (C) 2009 Jeremy Kerr <jk at ozlabs.org>
#
@@ -107,3 +109,26 @@ class MboxPassThroughHeaderTest(TestCase):
response = self.client.get('/patch/%d/mbox/' % self.patch.id)
self.assertContains(response, self.to_header)
+
+class MboxBrokenFromHeaderTest(TestCase):
+ """ Test that a person with characters outside ASCII in his name do
+ produce correct From header. As RFC 2822 state we must retain the
+ <user at doamin.tld> format for the mail while the name part may be coded
+ in some ways. """
+
+ def setUp(self):
+ defaults.project.save()
+ self.person = defaults.patch_author_person
+ self.person.name = u'©ool guŷ'
+ self.person.save()
+
+ self.patch = Patch(project = defaults.project,
+ msgid = 'p1', name = 'testpatch',
+ submitter = self.person, content = '')
+
+ def testFromHeader(self):
+ self.patch.save()
+ from_email = '<' + self.person.email + '>'
+
+ response = self.client.get('/patch/%d/mbox/' % self.patch.id)
+ self.assertContains(response, from_email)
--
1.7.10.4
More information about the Patchwork
mailing list