[PATCH 2/3] Make the post-receive hook more efficient (using pwclient info, not view)

Carl Worth cworth at cworth.org
Thu Dec 12 05:46:27 EST 2013

Older versions of patchwork shipped with a version of pwclient that
had the view command, but not info command. Now that info exists, it's
inefficient to use it to obtain the patchwork ID value, (since it
requires the server to send the entire patch content in response to an
XML RPC request).

So be kind to the server by using info instead, (which has a small,
fixed-length response).
 tools/post-receive.hook | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/post-receive.hook b/tools/post-receive.hook
index b2b89a2..d0b8e22 100755
--- a/tools/post-receive.hook
+++ b/tools/post-receive.hook
@@ -25,8 +25,8 @@ get_patchwork_hash()
   local id
-  id=$($PWDIR/bin/pwclient view -h $1 2>/dev/null \
-    | sed -rne 's,X-Patchwork-Id: ,,p')
+  id=$($PWDIR/bin/pwclient info -p mesa -h $1 2>/dev/null \
+    | sed -rne 's,- id[[:space:]]*: ,,p')
   echo $id
   test -n "$id"

More information about the Patchwork mailing list