[U-Boot-DM] Patchwork vs. UTF8

Andreas Bießmann andreas.devel at googlemail.com
Mon Sep 3 16:37:39 EST 2012


Dear Wolfgang Denk,

On 02.09.12 22:33, Wolfgang Denk wrote:
> Dear Andreas Bießmann,
> 
> In message <50439C1C.7050805 at googlemail.com> you wrote:
>>
>>> NOTE: it's not uboot specific, PW is now used by linux kernel too, so let=
>> 's stop
>>> this trouble ASAP.
>>
>> AFAIR there is a problem using 'pwclient git-am' with some mbox of mine
>> (really need to fix pwclient ...), but all my patches went to patchwork
>> without problems.
> 
> Lucky you.  I think therer are two problems.   One is that PW
> sometimes silently drops such patches.  The other is that pwclient
> cannot find the patch based on the computed hash.  I didn't check if
> one or both bugs hit here.    In any case, applying the patches
> through pwclient failed eith a "patch not found" error.

No, it is a bug related to utf-8 and wrong conversion of content in
patchwork:

---8<---
andreas at andreas-mbp % pwclient list -w "Andreas Bießmann" -s New
Patches submitted by Andreas Bießmann <andreas.devel at googlemail.com>:
ID    State        Name
--    -----        ----
137529 New          [U-Boot,v4] tools/env: add posibility to inject
configuration
176885 New          [U-Boot] dlmalloc: remove manual reloc alias warning
177964 New          [U-Boot] net:macb: add line break
177976 New          [U-Boot] avr32:portmux: fix setup for macb1
177978 New          [U-Boot] avr32: add atngw100mkii board
180195 New          [U-Boot,RFC] atmel:dataflash: remove unused mmc_mux
180943 New          [U-Boot] devkit8000: add rootwait to mmcboot option
andreas at andreas-mbp % pwclient git-am 177964
Applying patch #177964 using 'git am'
Description: [U-Boot] net:macb: add line break
Traceback (most recent call last):
  File "/Users/andreas/bin/pwclient", line 481, in <module>
    main()
  File "/Users/andreas/bin/pwclient", line 464, in main
    action_apply(rpc, patch_id, ['git', 'am'])
  File "/Users/andreas/bin/pwclient", line 272, in action_apply
    proc.communicate(s)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 729, in communicate
    self.stdin.write(input)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xdf' in
position 585: ordinal not in range(128)
--->8---

There may be some additional issues with 'patch not found' when working
with the hash. I did not discover these cause I do not work with hash
but use the id.

Best regards,

Andreas Bießmann


More information about the Patchwork mailing list