[PATCH] Allow to download public bundle as mbox
    Jeremy Kerr 
    jk at ozlabs.org
       
    Tue Nov  6 19:45:07 EST 2012
    
    
  
Hi Simo,
> Downloading single patches anonimously is allowed, we may as well allow
> downloading public bundles as mboxes.
Looks good. This does raise one question for everyone though:
>
> +def mbox_response(bundle, name):
>       response = HttpResponse(mimetype='text/plain')
> -    response['Content-Disposition'] = 'attachment; filename=bundle-%d.mbox' % \
> -        bundle.id
> +    response['Content-Disposition'] = 'attachment; filename=bundle-%s.mbox' % \
> +        name
>       response.write(bundle.mbox())
>       return response
Does anyone mind if we change the Content-Disposition HTTP header for 
downloading private bundles from the form:
    bundle-<ID>.mbox
to:
    bundle-<NAME>.mbox
?
In other words, does anyone rely on the bundle name to contain the ID?
Cheers,
Jeremy
    
    
More information about the Patchwork
mailing list