[PATCH] notifications: do not HTML-escape patch change notifications
Stefan Hajnoczi
stefanha at linux.vnet.ibm.com
Mon Jan 16 06:49:24 EST 2012
Patch change notifications are text/plain emails and should not
HTML-escape patch names. This means quotes and ampersands in patch
names should not be turned into " and & HTML entities.
Signed-off-by: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com>
---
I spotted the following in the patch change notification I received:
'''
The following patch (submitted by you) has been updated in patchwork:
* parser: allow words starting with "diff" at beginning of line
- http://patchwork.ozlabs.org/patch/136093/
'''
Notice that "diff" is "diff" because of Django's automatic HTML
escaping. I'm sending this patch to fix that - but I have not tested this
patch!
templates/patchwork/patch-change-notification.mail | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/templates/patchwork/patch-change-notification.mail b/templates/patchwork/patch-change-notification.mail
index d86a6af..19a2a09 100644
--- a/templates/patchwork/patch-change-notification.mail
+++ b/templates/patchwork/patch-change-notification.mail
@@ -2,7 +2,7 @@ Hello,
The following patch{{notifications|length|pluralize:"es"}} (submitted by you) {{notifications|length|pluralize:"has,have"}} been updated in patchwork:
{% for notification in notifications %}
- * {{notification.patch.name}}
+ * {{notification.patch.name|safe}}
- http://{{site.domain}}{{notification.patch.get_absolute_url}}
was: {{notification.orig_state}}
now: {{notification.patch.state}}
--
1.7.8.3
More information about the Patchwork
mailing list