[PATCH 1/2] Use an explicit initial default patch state

Jeremy Kerr jk at ozlabs.org
Mon Apr 30 19:37:01 EST 2012


Hi Wolfgang,

> Um... but is it really working?


Is is, but:

> I added "X-patchwork-state: Accepted" to a reply on a patch; my reply
> was correctly added to the respective PW entry
> (http://patchwork.ozlabs.org/patch/155545/) but the status did not
> change.


The patches Dirk sent don't do this; they allow the state to be set on 
the *original mail*, when the patch is first parsed.

The issue with allowing the state to be updated is that there isn't a 
method to authenticate the sender, and ensure that they're a maintainer 
of the project. It's possible to look at the From: field, but that's 
easily faked. In effect, I could send mail to 
incoming at patchwork.ozlabs.org, and set all of the buildroot patches to 
Rejected.

If anyone has useful ideas on how patchwork could do proper 
authentication, then I'd be happy to implement this.

It if suits, you could achieve the same thing with a git hook, which 
sets the patchwork state (using pwclient) when it's applied to your tree.

Cheers,


Jeremy


More information about the Patchwork mailing list