[PATCH v2] Recognize mail headers for delegate and state

Dirk Wallenstein halsmit at t-online.de
Tue Apr 24 21:15:15 EST 2012


On Tue, Apr 24, 2012 at 08:33:29AM +0200, Wolfgang Denk wrote:
> Dear Dirk Wallenstein,
> 
> In message <1296054749-13453-1-git-send-email-halsmit at t-online.de> you wrote:
> > Introduce two new Patchwork mail headers that determine the initial
> > state and delegate of a patch.  They take a state name as displayed in
> > Patchwork and the email address of the wanted delegate.  An example:
> ...
> 
> Upon Jeremy Kerr's comment you replied:
> > >
> > > > +default_patch_state = 'New'
> > > 
> > > We're duplicating the default-state logic provided in Patch.save() here, which 
> > > uses the database for a lookup (there may not be a 'New' state). It would be 
> > > better to leave the state un-set in this case, rather than selecting a 
> > > default, then falling back to the default provided in the save() method.
> > 
> > Ups, missed that.
> > 
> > > Also, could you add a testcase for these? Let me know if you'd like any help 
> > > with that.
> > 
> > Just want to say that I'm on it, but I'm having a bit of a cold
> > currently, so it might still take a bit.
> 
> Has anything happened after that?
> 
> I'd really appreciate to have such a feature.

The feature is present.  I remember, I was trying to take a step back
and create another test base class for the test but a WIP factory by
Guilherme was preferred at that time.  So, AFAICT the feature is present
but a test is missing.

-- 
Cheers,
  Dirk


More information about the Patchwork mailing list