Dealing with duplicated hashes
Wolfgang Denk
wd at denx.de
Thu Oct 6 00:55:15 EST 2011
Dear Jeremy,
In message <20110915061058.1AC891408E98 at gemini.denx.de> I wrote:
>
> In message <1316064427.2768.40.camel at pororo> you wrote:
> >
> > > I came to the conclusion that the current behaviour is actually a bug.
> > > I have seen cases where new patch versions were sent because changes
> > > to the commit message were requested - yet pwclient will always access
> > > the old patch, and thus eventually apply the wrong one.
> >
> > Yeah, bug or not, it's definitely not desirable behaviour.
> >
> > However, solving it in a comprehensive way doesn't seem obvious - we
> > could return an error when there are multiple hash matches, or perhaps
> > default to the most recent patch. But both of these are a little
> > imprescice, will this be okay for your usage?
>
> I think there are two use cases:
>
> - In most cases we want to use the most recent one. So this should be
> the default.
>
> If there are multiple hash matches, it would probably be helpful if
> a warning was issued (which might, for example, contain the numbers
> of the matching patches and their states).
>
> - In some cases (when changing state) it would be nice to be able to
> operate on all patches at once; maybe pwclient could have some
> "--all" flag for such cases?
>
> Thanks!
Any chance to see this fixed any time soon?
Thanks in advance.
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You got to learn three things. What's real, what's not real, and
what's the difference." - Terry Pratchett, _Witches Abroad_
More information about the Patchwork
mailing list