[PATCH] Add a source_tree field to Project.

Janne Grunau janne-ffmpeg at jannau.net
Wed Mar 30 21:59:13 EST 2011


Hej,

On Wed, Mar 30, 2011 at 02:56:35PM +0800, Jeremy Kerr wrote:
> 
> > I would like to use it for patches.libav.org to link the commit hash to
> > that commit in gitweb. see http://patches.libav.org/patch/1927/ for an
> > example.
> 
> Hm, good idea.
> 
> > It probably needs another field to construct the full URL from source
> > tree and commit_ref.
> 
> I think this could be fairly independent of the source tree: I'd imagine that 
> this could be implemented with a format-string style field on the Project 
> instance:
> 
>  commit_url = 'http://git.ozlabs.org/?p=patchwork;a=commitdiff;h=%s'
> 
> - we then format with (project.commit_url % patch.commit_ref) to create the 
> link.
> 
> I'm happy to add this, but I think it's a separate change to the one that 
> Guilherme is planning. Guilherme - do you agree?

That would work too and is cleaner.

Janne


More information about the Patchwork mailing list