Using the From: address specified in the body

Peter Maydell peter.maydell at
Sat Mar 19 08:43:29 EST 2011

On 18 March 2011 22:33, Guilherme Salgado <guilherme.salgado at> wrote:
> On Fri, 2011-03-18 at 09:23 -0300, Mauro Carvalho Chehab wrote:
>> Em 17-03-2011 19:20, Peter Maydell escreveu:
>> > For completeness, should we support the git am "Subject: can
>> > be at the start of the body" syntax too?
>> I think that, if such support is added on patchwork (both from: and subject:
>> replacements), the better would be to output them as a patchwork-specific
>> meta-data at the emails, like:
> We should store them in the DB in a structured fashion, but once we have
> that it's trivial to include it in the mbox file that patchwork provides
> for every patch, which i think is what you want?

Ew. The mbox should always be the mail as received by patchwork,
in my opinion, not some reconstituted near-equivalent. I would have thought
the main reason for patchwork to parse these From:-lines-in-body would
be so its web display could get the author right.

I want to be able to download the mbox file and run 'git am' on it
and have it do the right thing. If you remove the From lines from
the body and turn them into patchwork-specific headers you break
that use case.

-- PMM

More information about the Patchwork mailing list