patch tracking issue

[Simon Guinot]

Hi Albert,

On Wed, Jun 15, 2011 at 01:45:18PM +0200, Albert ARIBAUD wrote:
> Le 15/06/2011 10:48, Simon Guinot a écrit :
> >Hi Jeremy,
> >
> >On Wed, Jun 15, 2011 at 09:44:56AM +0800, Jeremy Kerr wrote:
> >>Hi Simon,
> >>
> >>>Did you learn something from my patch email ? Any clue about this weird
> >>>behaviour ?
> >>Yes - sorry about the delay though.
> >No problems.
> >
> >>It looks like the mail can't be decoded correctly. The content type of
> >>the patch part is:
> >>
> >>         Content-Type: text/plain
> >>         Content-Disposition: inline; filename=mutt-kw-1000-6693-519
> >>         Content-Transfer-Encoding: quoted-printable
> >>
> >>Since there is no encoding specified, patchwork assumes UTF-8.
> >>
> >>However, you have the following text in the patch:
> >>
> >>          Marius Gr=F6ger<mag at sysgo.de>
> >>
> >>\xf6 is not a valid UTF-8 sequence, so patchwork can't reliably
> >>represent the patch data. At the moment, that means that the parse
> >>fails.
> >>
> >>So - how was this mail generated?
> >The email was generated using git-format-patch and sent using
> >git-send-email. I think the patch is correct.
> >
> >Actually, \xf6 is the iso-8859-{1,2,3,4} representation for 'ö' and
> >it is the way this character is encoded within the original source file.
> >Probably it should be fixed.
> >
> >Thanks for your help :)
> >
> >Simon
> We should involve Wolfgang here, because ISTR there were already
> discussions about encodings in U-Boot, with the conclusion at the
> time that ISO-8859 was to be used:
> 
> <http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/84647>
> 
> Maybe finally we should move to UTF-8?

Anyway, my patch is wrong (even if I said the exact opposite earlier :).
Depending the patch version, the encoding information is either missing
or specified as UTF-8. Both case are wrong.

The patch encoding would be ISO-8859-1 which is the current encoding for
the MAINTAINERS file (and hopefully for the whole source repository).

Regards,

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20110615/54c35fd4/attachment.pgp>