Patches in attachments

Dirk Wallenstein halsmit at t-online.de
Thu Jan 20 22:32:07 EST 2011


On Fri, Jan 14, 2011 at 10:17:25AM +0100, Sedat Dilek wrote:
> 
> [ CCing patchwork ML ]
> 
> Can you send your patch separately, please?
> Within a (long) thread it is eaten up.
> 
> As *.patch are somehow not presented as diff (see [1]), someone can't
> catch them from <patchwork.k.o>.

Just some thoughts...

Patches in attachments don't really work currently, except when it is
only the diff as part of a mail that acts as a patch-mail.  Supporting
attachments like [2] looks like a more comprehensive change.  Would it
be safe to say that an attached patch can always be independently parsed
as mail and if not present, the Subject, From, and Date fields can be
taken from the main part?

However there remains the problem that there would possibly be two
comments on the patch (from the attachment and from the main mail) that
would be both identified by the message-id plus Patch.  But only the one
from the attachment should be used when creating the mbox.

[2] http://lists.ozlabs.org/pipermail/patchwork/2011-January/000354.html

-- 
Greetings,
Dirk


More information about the Patchwork mailing list