[PATCH] Ensure consecutive patch header lines

Jeremy Kerr jk at ozlabs.org
Mon Feb 28 12:29:13 EST 2011

Hi Dirk,

> Reset the state if we can't proceed after the optional extended header
> line.

I was originally intending for patchwork to be fairly permissive with what it 
accepts as part of the patch, as patch(1) is happy to ignore stuff that isn't 
part of the actual patch. Looks like it's being *too* permissive though.

I think a nicer fix would be to drop the current parse buffer (ie, make it 
part of the comment) if we see '^diff' again, rather than allowing for only 
one line between '^diff' and '^--- '. This way we should only see entire hunks 
ending up in the patch bufffer.



More information about the Patchwork mailing list