[PATCH] Fix parsemail-batch.sh

Jeremy Kerr jk at ozlabs.org
Thu Feb 17 01:38:38 EST 2011


Hi Guilherme,

> It was broken because it was using 'ls -l' as the input for the while loop,
> which means the file modes, owner and times ended up together with the file
> names themselves.

That's a '1' (one), not an 'l'. Removing it will break the script.

> I also changed it to use parsemail.sh instead of parsemail.py as the former
> sets the required environment variables that were being set in
> parsemail-batch.sh.

Makes sense.

> --- a/apps/patchwork/bin/parsemail-batch.sh
> +++ b/apps/patchwork/bin/parsemail-batch.sh
> @@ -19,7 +19,7 @@
>  # along with Patchwork; if not, write to the Free Software
>  # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 
> USA
> 
> -PATCHWORK_BASE="/srv/patchwork"
> +HERE=`dirname $0`

Maybe call this PATCHWORK_BINDIR, so it's a little more obvious what to 
replace this with if they move one of the scripts?

Cheers,


Jeremy


More information about the Patchwork mailing list