Test failures

[Guilherme Salgado]

On Mon, 2011-02-07 at 16:13 -0200, Guilherme Salgado wrote:
> Hi there,
> 
> I'm getting some test failures on a pristine branch of patchwork which I
> was hoping to fix so that I can more easily catch breakage introduced by
> my own changes, but I thought I'd first check here if these are known
> and/or if somebody is already working on them.
> 
> The first one is seemingly because python's email package doesn't work
> well with unicode (<http://bugs.python.org/issue1685453>). Has anybody
> seen these before and/or tried to fix them?

Actually, this failure was introduced by commit
7fd7d0bbe4e3fce405e02e9e630ef70023fdd43e and a fix for it has been
posted already:
http://lists.ozlabs.org/pipermail/patchwork/2011-January/000354.html

> 
>         ERROR: testCommentContent (patchwork.tests.patchparser.UTF8InlinePatchTest)
>         ----------------------------------------------------------------------
>         Traceback (most recent call last):
>           File "/home/salgado/devel/patchwork/apps/patchwork/tests/patchparser.py", line 85, in setUp
>             (self.patch, self.comment) = find_content(self.project, email)
>           File "/home/salgado/devel/patchwork/apps/patchwork/bin/parsemail.py", line 175, in find_content
>             (patchbuf, c) = parse_patch(payload)
>           File "/home/salgado/devel/patchwork/apps/patchwork/parser.py", line 66, in parse_patch
>             for line in text.decode('utf-8').split('\n'):
>           File "/usr/lib/python2.6/encodings/utf_8.py", line 16, in decode
>             return codecs.utf_8_decode(input, errors, True)
>         UnicodeEncodeError: 'ascii' codec can't encode character u'\xeb' in position 146: ordinal not in range(128)
> 
> 
> This one may be thanks to my environment (Maverick), but it'd be nice to
> figure out whether it's a bug somewhere or just the test that needs to
> be updated because python-django-registration changed in Maverick.  Any
> ideas?
> 
>         FAIL: test_registration_view (registration.tests.RegistrationViewTests)
>         ----------------------------------------------------------------------
>         Traceback (most recent call last):
>           File "/usr/lib/pymodules/python2.6/registration/tests.py", line 289, in test_registration_view
>             self.assertEqual(response.status_code, 302)
>         AssertionError: 200 != 302
> 
> Cheers,
> 

-- 
Guilherme Salgado <https://launchpad.net/~salgado>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20110207/172d36ad/attachment.pgp>